From 947d3195085487dc60f229c90efd0ce88a24be0e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20Jirman?= Date: Tue, 23 Nov 2021 17:58:05 +0100 Subject: [PATCH 378/484] usb: typec: tcpm: Improve logs This adds clarity to debugging. Signed-off-by: Ondrej Jirman --- drivers/usb/typec/tcpm/tcpm.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c index ce96f3d58e02..b6008a2b3efa 100644 --- a/drivers/usb/typec/tcpm/tcpm.c +++ b/drivers/usb/typec/tcpm/tcpm.c @@ -986,10 +986,13 @@ static int tcpm_pd_transmit(struct tcpm_port *port, break; } - if (msg) + if (msg) { tcpm_log(port, "PD TX, header: %#x", le16_to_cpu(msg->header)); - else + for (ret = 0; ret < pd_header_cnt_le(msg->header); ret++) + tcpm_log(port, " tx payload[%d]: %#x", ret, le32_to_cpu(msg->payload[ret])); + } else { tcpm_log(port, "PD TX, type: %#x", tx_sop_type); + } reinit_completion(&port->tx_complete); ret = port->tcpc->pd_transmit(port->tcpc, tx_sop_type, msg, negotiated_rev); @@ -3740,6 +3743,10 @@ void tcpm_pd_receive(struct tcpm_port *port, const struct pd_message *msg, enum tcpm_transmit_type rx_sop_type) { struct pd_rx_event *event; + int ret; + + for (ret = 0; ret < pd_header_cnt_le(msg->header); ret++) + tcpm_log(port, " rx payload[%d]: %#x", ret, le32_to_cpu(msg->payload[ret])); event = kzalloc(sizeof(*event), GFP_ATOMIC); if (!event) @@ -6043,7 +6050,7 @@ static void _tcpm_cc_change(struct tcpm_port *port, enum typec_cc_status cc1, static void _tcpm_pd_vbus_on(struct tcpm_port *port) { - tcpm_log_force(port, "VBUS on"); + tcpm_log_force(port, "VBUS event received: on"); port->vbus_present = true; /* * When vbus_present is true i.e. Voltage at VBUS is greater than VSAFE5V implicitly @@ -6133,7 +6140,7 @@ static void _tcpm_pd_vbus_on(struct tcpm_port *port) static void _tcpm_pd_vbus_off(struct tcpm_port *port) { - tcpm_log_force(port, "VBUS off"); + tcpm_log_force(port, "VBUS event received: off"); port->vbus_present = false; port->vbus_never_low = false; switch (port->state) { -- 2.49.0